Replace u/npc_has_var with compare_string #76036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Got told that u/npc_has_var is on a chopping block, because it does the same thing as compare_string, but limited to only two scopes out of four
Well if it's on a chopping block, let's chop it
Describe the solution
Use regex to replace all uses of u/npc_has_var with compare_string
Fix manually the rest that was not hit with regex
Testing
TBD
Additional context
Regex used:
copy of #76006 without conflicts with #75392