Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete ACRs #76034

Merged
merged 5 commits into from
Sep 9, 2024
Merged

Obsolete ACRs #76034

merged 5 commits into from
Sep 9, 2024

Conversation

Holli-Git
Copy link
Contributor

Summary

Bugfixes "Obsolete ACRs"

Purpose of change

The Remington ACR is an experimental firearm that saw 0 adoption anywhere, so it should be removed. I can't even find much information about it because google keeps thinking about the Bushmaster ACR.

Describe the solution

Removes it.

Describe alternatives you've considered

Testing

image
image

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) <Bugfix> This is a fix for a bug (or closes open issue) labels Aug 29, 2024
@github-actions github-actions bot requested a review from I-am-Erk August 29, 2024 18:25
@github-actions github-actions bot added [Python] Code made in Python Code: Tooling Tooling that is not part of the main game but is part of the repo. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 29, 2024
@sonphantrung
Copy link
Contributor

sonphantrung commented Aug 30, 2024

I saw this Wikipedia post, have you taken a look at this? The Bushmaster AFAICT is just a variant of the Remington

@Testudo-Cultu
Copy link
Contributor

The Bushmaster ACR is typically what I'd expect to be chambered in .300 BLK, so it looks a bit like the person that contributed this in the first place may have gotten the Remington and Bushmaster ACRs backwards. I don't think it's true that the Remington ACR is an experimental firearm; I believe it simply did not succeed the US Army's competition to find a replacement to the M4 and wound up flopping in this arena. I basically never see or hear about law enforcement using it, but it was sold to them and a few foreign militaries (not that it matters much in the purview of what you'd likely find in New England).

There is no Bushmaster ACR in the game, and it's already chambered like a Bushmaster ACR, so why not just rename it from Remington to Bushmaster and fix up the description?

@Holli-Git
Copy link
Contributor Author

I saw this Wikipedia post, have you taken a look at this? The Bushmaster AFAICT is just a variant of the Remington

Yes. I did. One of the things it says it the Remington is full-auto while the Bushmaster is semi-auto as one is for military and one is for civilian market. So military/police would be paying a whole lot more for what is at the end of the day an M4, and for civilian, not enough hits on gunbroker. I can also find no evidence of any police/military using the ACR except for a photo of them in use by polish forces in Afghanistan.

@Holli-Git
Copy link
Contributor Author

There is no Bushmaster ACR in the game, and it's already chambered like a Bushmaster ACR, so why not just rename it from Remington to Bushmaster and fix up the description?

Because the Bushmaster is semi-auto only, as it's for the civilian market. Not enough hits on gunbroker.

@Testudo-Cultu
Copy link
Contributor

Testudo-Cultu commented Aug 30, 2024

Because the Bushmaster is semi-auto only, as it's for the civilian market. Not enough hits on gunbroker.

I'm aware the Bushmaster isn't fully auto, I just didn't mention that because it's by far the most trivial thing (what I really meant was least appealing to my zoomy brain receptors) to change. I didn't expect so few hits on Gunbroker, though. Fair enough to remove it on this basis alone, in my opinion.

@Maleclypse
Copy link
Member

Conflict in the variant validator

@Holli-Git
Copy link
Contributor Author

Conflict in the variant validator

Should be fixed now

@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2024
@Holli-Git Holli-Git closed this Sep 5, 2024
@Holli-Git Holli-Git reopened this Sep 5, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 6, 2024
@Maleclypse Maleclypse merged commit cdadd85 into CleverRaven:master Sep 9, 2024
36 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Code: Tests Measurement, self-control, statistics, balancing. Code: Tooling Tooling that is not part of the main game but is part of the repo. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns [Python] Code made in Python Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants