fix ImTui rendering by defining the IMTUI define #76031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OTHERS variable was already used further up in the Makefile to construct CXXFLAGS. We should just modify DEFINES instead, which is used below to construct the actual compiler commands. Fixes CleverRaven#75362
github-actions
bot
added
Code: Build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "make ImTui render text as text, so that the players can read our spiffy new menus"
Purpose of change
So that the player can tell what the game is asking them, we should render text as text.
Describe the solution
We just need to actually add -DIMTUI to the command line. We do that by adding it to the DEFINES variable.
Testing
Ran the game. Can read the text in the Load Character menu!
Additional context
Fixes #75362