Replace pf_special with a scoped enum (PathfindingFlag) and add more flags #76026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLIDragon
force-pushed
the
pathfinding-flag
branch
from
cc802bb to
4a30154
Compare
github-actions
bot
added
the
[C++]
CLIDragon
force-pushed
the
pathfinding-flag
branch
from
4a30154 to
28819aa
Compare
github-actions
bot
added
astyled
CLIDragon
force-pushed
the
pathfinding-flag
branch
from
84c0d22 to
75e76c9
Compare
|
Clang tidy failure is unrelated; this should be ready to merge. |
The current flags do not support all functionalities required (e.g. whether a piece of terrain is sheltered or unsheltered), and lack granularity with e.g. GOESUPDOWN requiring extra checks for ramps, whether it goes up or goes down, and so forth. Additionally, using a scoped enum is good practice and will hopefully prevent accidental misuse of the enum type. Part of CleverRaven#75945. The additional flags aren't presently used as they are intended to be part of a new pathfinding implementation. Co-authored-by: prharvey <[email protected]>
CLIDragon
force-pushed
the
pathfinding-flag
branch
from
75e76c9 to
d2b1fa8
Compare
|
Hopefully tests pass. |
|
I have no idea how to read or fix the ASAN error. I think it's unrelated because it looks to be in ui code, but again, no idea. I would appreciate it if someone with more experience with ASAN could take a look. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
The current flags do not support all functionalities required (e.g. whether a piece of terrain is sheltered or unsheltered), and lack granularity with e.g. GOESUPDOWN requiring extra checks for ramps, whether it goes up or goes down, and so forth.
Additionally, using a scoped enum is good practice and will hopefully prevent accidental misuse of the enum type.
Describe the solution
Part of #75945. The additional flags aren't presently used as they are intended to be part of a new pathfinding implementation.
I've assigned the
RAMPflag to implyGOESUPand notGOESDOWN. I'm not sure if this is correct.Describe alternatives you've considered
Testing
There have been exactly zero functionality changes. The new flags are compatible with the old ones, and have been swapped in where appropriate. If it compiles, it should run.
Additional context