-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more generic gun names #76019
Merged
Merged
Add more generic gun names #76019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[Python]
Code made in Python
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
<Bugfix>
This is a fix for a bug (or closes open issue)
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Aug 28, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 28, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 28, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 29, 2024
Uwuewsky
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
DSeyka
reviewed
Aug 29, 2024
Co-authored-by: DSeyka <[email protected]>
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
…clysm-DDA into more_gun_variants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Bugfix>
This is a fix for a bug (or closes open issue)
Code: Tooling
Tooling that is not part of the main game but is part of the repo.
Items: Ammo / Guns
Ammunition for all kinds of weapons and these weapons themselves
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Python]
Code made in Python
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Adds some missing gun variants"
Purpose of change
There was some guns with missing gun variant names and descriptions so I decided to add some.
Describe the solution
Adds some, along with some more history behind the guns.
Describe alternatives you've considered
Not doing this
Testing
Additional context
Putting this as draft so I can have some feedback, and if I feel like adding more descriptions. Might knock out the black powder revolvers next