Extract game::find_stairs from game::find_or_make_stairs
#75963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of CleverRaven#74945. Sometimes we want to find stairs without spontaneously generating them.
github-actions
bot
added
[C++]
|
@kevingranade @Procyonae this does pass basic build. I don't believe the clang error is related to this, I don't feel comfortable in my understanding of mapgen to review this. Please review and approve if you feel like it's good to go. |
Knut-Aage-Hofseth
pushed a commit
to Knut-Aage-Hofseth/Cataclysm-DDA
that referenced
this pull request
Aug 29, 2024
…#75963) Part of CleverRaven#74945. Sometimes we want to find stairs without spontaneously generating them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Part of #74945. Sometimes we want to find stairs without spontaneously generating them. In addition, we reduce a ~200 line function into an ~50 line function and a ~150 line function.
Describe the solution
Describe alternatives you've considered
Testing
This is a direct refactor - if it builds it will work the same as before.
Additional context