Add a variant of closest_points_first that takes a predicate #75961
+131
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[C++]
|
I'm not sure why this is failing. Building succeeds on my machine, and I've included point.h in all of the referenced files. |
CLIDragon
force-pushed
the
closest_points_first
branch
from
6747a37 to
a40e8ac
Compare
GuardianDll
reviewed
Sep 4, 2024
CLIDragon
force-pushed
the
closest_points_first
branch
2 times, most recently
from
878aded to
0dde0b1
Compare
|
Build failures appear to be unrelated, though I would prefer to rerun to check. |
|
sadly can't be fixed by rerun, #76349 need to be merged first |
CLIDragon
force-pushed
the
closest_points_first
branch
from
31a322b to
87aab5e
Compare
|
Can you resolve conflicts? |
CLIDragon
force-pushed
the
closest_points_first
branch
from
44f5890 to
6abaf58
Compare
|
Merge conflicts resolved. |
CLIDragon
force-pushed
the
closest_points_first
branch
from
6abaf58 to
e622774
Compare
github-actions
bot
added
astyled
|
Is clang angry from this PR or some other reason? |
Yes, it's this PR. I should probably mark as draft until I get around to fixing the issues. |
github-actions
bot
removed
the
astyled
github-actions
bot
added
the
astyled
|
Could you please resolve conflicts? |
Part of CleverRaven#75945. The variant will be used in pathfinding to find the nearest ramp or stairs without having to enumerate all points. * Make find_point_closest_first generic over point and tripoint. * Extract common code between closest_points_first variants Co-authored-by: prharvey <[email protected]>
CLIDragon
force-pushed
the
closest_points_first
branch
from
e87af08 to
d488bbe
Compare
github-actions
bot
removed
the
astyled
github-actions
bot
added
the
astyled
github-actions
bot
removed
the
astyled
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
the
astyled
github-actions
bot
added
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Part of #75945. The variant will be used in pathfinding to find the nearest ramp or stairs without having to enumerate all points.
Describe the solution
Adds a variant of
closest_points_first,find_closest_points_firstthat takes a predicate function. It is generic over point and tripoint, thereby avoiding a double allocation intripointvariants.Describe alternatives you've considered
The bounds check could be skipped by adding an inbounds variant, but this is certainly too much work to skip three checks.
Using
std::variantinstead oftypename Point. I'm not particularly biased towards one way or another.Testing
As long as current
closest_points_firsttests pass, this will have been implemented correctly.Additional context