Fix #73172

[alef]

Summary

Bugfixes "Workaround gcc v11.4.0 bug"

Purpose of change

Avoid the compiler error reported in #73172

Describe the solution

Surround abstract_var_info with compiler pragmas to avoid checking for possibly use of uninitialized variables. The same code does not error with gcc v12 as tested on godbolt.org.

Describe alternatives you've considered

Testing

Built on WSL2 g++ (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0 and MSVC/CMake.

Additional context

[andrei8l]

This breaks compilation with clang. It should have been wrapped in #if defined(__GNUC__) && !defined(__clang__), like here

Cataclysm-DDA/src/cata_small_literal_vector.h

Lines 163 to 170 in 83b5393

	#if defined(__GNUC__) && !defined(__clang__)
	#pragma GCC diagnostic push
	#pragma GCC diagnostic ignored "-Wmaybe-uninitialized"
	#endif
	heap = static_cast<T *>( std::realloc( heap_, sizeof( T ) * new_capacity ) );
	#if defined(__GNUC__) && !defined(__clang__)
	#pragma GCC diagnostic pop
	#endif

[kevingranade]

On clang what? It built here with Clang 10, Clang 12, and Clang 14 on macOS.
I'm not saying you're wrong, but how did this make it through our build without catching the breakage?

[andrei8l]

No, I am wrong. My failure is from -Wunknown-warning-option, which is disabled here by Wno-unknown-warning-option but not in my tree. Sorry...

[kevingranade]

No problem. I thought I remembered that clang might not respect that in some circumstances.

False alarms are better than missed alarms...