Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix driveway of in-construction house_01 #75898

Merged
merged 1 commit into from
Aug 24, 2024

Conversation

HadeanLake
Copy link
Contributor

@HadeanLake HadeanLake commented Aug 23, 2024

Summary

None

Purpose of change

Fix #75808
in-construction variant of house_01 has empty window frames, window walls or wooden floors in front of garage where you would expect complete or in-construction concrete driveway.
Unsaved Image 1

Describe the solution

Changed those tiles to be same as walkway from there to main entrance. Depending on phase of construction those may become concrete, dirt or shallow pit that concrete have not been poured in yet

Describe alternatives you've considered

Testing

Changed the weights so that only in-construction variant spawns during testing session
Used overmap editor to spawn many house_01 and make sure 3x6 area in front of garage makes sense
2024-08-23-145507_1920x1080_scrot

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 23, 2024
@Maleclypse Maleclypse merged commit 1d2312b into CleverRaven:master Aug 24, 2024
27 checks passed
@HadeanLake HadeanLake deleted the house01 branch August 24, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window filled driveway
2 participants