Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent automatic assignment of hotkeys to passive mutations #75896

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

kightlygeorge
Copy link
Contributor

@kightlygeorge kightlygeorge commented Aug 23, 2024

Summary

Interface "Prevent automatically assigning keys to passive mutations"

Purpose of change

Stops passive mutations from being assigned characters. I've already done this with bionics, but I forgot that mutations did this too.

Describe the solution

During invlet assignment, check if the mutation is active before assigning an invlet

Testing

Created a new character with several passive and active mutations. Only active mutations had hotkeys.

Additional context

Mutation hotkeys are assigned every time the mutations menu is opened instead of being persistent for some reason.

@github-actions github-actions bot added Info / User Interface Game - player communication, menus, etc. Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 23, 2024
@Maleclypse Maleclypse merged commit 6c57eea into CleverRaven:master Aug 23, 2024
23 of 29 checks passed
@NetSysFire NetSysFire added the Controls / Input Keyboard, mouse, keybindings, input UI, etc. label Aug 23, 2024
@kightlygeorge kightlygeorge deleted the mutation_invlets branch August 24, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Controls / Input Keyboard, mouse, keybindings, input UI, etc. Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants