Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract graffiti text and vision levels names #75894

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

Uwuewsky
Copy link
Contributor

@Uwuewsky Uwuewsky commented Aug 23, 2024

Summary

None

Purpose of change

Mapgen graffiti and visibility levels were not translatable.

Describe the solution

String extractor fixed.

REVERTED uh, while I was checking the work, I made another guerrilla change, I swapped the names of the levels for water bodies, I'm quite sure that this name is for single-overmap-tile ponds and the like, but calling a part of a river or lake a water body is not quite right. correct me if i'm wrong.

Describe alternatives you've considered

Testing

graffiti on the newly created irradiator_1_4 is translated
vision1

Additional context

@github-actions github-actions bot added Translation I18n [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [Python] Code made in Python labels Aug 23, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Dufresne was here

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 23, 2024
@PatrikLundell
Copy link
Contributor

I'm not a native English (or American, for that matter) speaker, but I think your guerilla change is misguided. The preexisting comments even contradict your changes.

As far as I understand, a "body of water" is a contiguous volume of water, like a lake, sea, or ocean, with rivers being sometimes a body and sometimes sort of discrete pockets depending on how contiguous it is. A puddle wouldn't be large enough to have a "body", and I wouldn't consider single tile ponds to really have one either.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 23, 2024
@dseguin dseguin merged commit 1373a63 into CleverRaven:master Aug 26, 2024
23 checks passed
@Uwuewsky Uwuewsky deleted the graffiti branch August 26, 2024 05:09
Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display [Python] Code made in Python Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants