Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No cost to turn off #75892

Merged

Conversation

Maleclypse
Copy link
Member

Summary

None

Purpose of change

It was pointed out to me that some items cost a charge of energy to turn off in addition to the turn on cost. So I went and looked. Changed almost all the ones I found and found a couple items with Turn off as their Turn on message so I changed them.

Describe the solution

"ammo_scale": 0,

Describe alternatives you've considered

I'll leave this up for a bit for people to review if they believe certain items should have a power down cost.

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Items: Armor / Clothing Armor and clothing labels Aug 23, 2024
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Aug 23, 2024
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 23, 2024
@RedMisao
Copy link
Contributor

This is adressing #75632 (?). If that's the case, it should close it after merging.

@Maleclypse
Copy link
Member Author

This is adressing #75632 (?). If that's the case, it should close it after merging.

No it's not addressing that. Devices should take a charge when turned on to prevent the PC from making the game miserable by turning things on and off in the same second just to see where monsters are without the monsters seeing you.

@RedMisao
Copy link
Contributor

My bad, I misread the title of the issue.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 23, 2024
@Fris0uman Fris0uman merged commit b44ed93 into CleverRaven:master Aug 26, 2024
24 checks passed
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 26, 2024
* No cost to turn off

* lint

---------

Co-authored-by: Anton Simakov <[email protected]>
@MikasaTanikawa
Copy link
Contributor

Devices should take a charge when turned on to prevent the PC from making the game miserable by turning things on and off in the same second just to see where monsters are without the monsters seeing you.

But this already covered by lit up status effect. It sticks to PC at least for one second.

Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
* No cost to turn off

* lint

---------

Co-authored-by: Anton Simakov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Melee Melee weapons, tactics, techniques, reach attack Mods: Aftershock Anything to do with the Aftershock mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants