Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

towers are vaguely seen as tall buildings #75879

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

sonphantrung
Copy link
Contributor

Summary

None

Purpose of change

Simple word change to be in line with "vaguely seen" status

Describe the solution

Changed the name

Describe alternatives you've considered

I could've made most of the towers instantly visible, but I find it quite wonky, so I leave it for now

Testing

Should work

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 22, 2024
@Karol1223
Copy link
Contributor

Aren't those used for things like fungal towers and migo towers as well? Which probably don't look like buildings at all.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 23, 2024
@sonphantrung
Copy link
Contributor Author

Yeah, which I'll plan to move 'em as "alien building/structure" in the near future.

@Karol1223
Copy link
Contributor

Why not just do it here and avoid the weirdness entirely instead of pushing it to some hypothetical future PR?

@github-actions github-actions bot added the Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. label Aug 23, 2024
@sonphantrung
Copy link
Contributor Author

Yeah, you're right, I actually thought the scale would be larger, which turns out to be trivial (fungal towers are blends_till_details btw)

@Fris0uman Fris0uman merged commit f4f4b63 into CleverRaven:master Aug 26, 2024
24 checks passed
alef pushed a commit to alef/Cataclysm-DDA that referenced this pull request Aug 26, 2024
* towers are vaguely seen as tall buildings

* move mi-go towers to alien towers
Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
* towers are vaguely seen as tall buildings

* move mi-go towers to alien towers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants