Removed descriptions for reloaded and black powder rounds #75874
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Interface "Removed descriptions for reloaded and black powder rounds"
Purpose of change
Initially, I moved the repeating text into snippets, because 99.99% of such descriptions are simply a description of the factory round + a small explanation. It was all good, but not being able to add some text to the parent item description without copying it makes it less useful, and the text becomes more cluttered. And it's a bit hard to maintain.
Describe the solution
So I removed those descriptions in favor of effect (
RECYCLED
,BLACKPOWDER
,MATCHHEAD
) descriptions. There are about 5 unchanged exceptions where this description differed from a simple concatenation with a "snippet".Also, I changed the description of the effect in
item.cpp
similar to what was in the descriptions of the items (see third commit).The second commit contains unrelated minor fixes that I noticed. I didn't put them in a separate PR because of possible merge conflicts.
Describe alternatives you've considered
Testing
Almost every ammo has a description of the parent.
Additional context