Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MoM] Further concentration updates #75851

Merged

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 21, 2024

Summary

Mods "[MoM] Further concentration updates"

Purpose of change

Noticed when I was working on #75795 that there was separate handling for dazed and downed when there doesn't need to be, and things like conjunctivitis and boomered that should affect your concentration limit do not.

Describe the solution

Add more effects to the list of things that reduce concentration. Make concentration extra-likely to break if the concentration calculations indicate you can concentrate on a negative number of powers. Remove the special handling for dazed and downed.

Make Master Concentration twice as effective, since there are many more effects that reduce your limit now.

Describe alternatives you've considered

Testing

Got boomered, lost concentration.

Additional context

@Standing-Storm Standing-Storm marked this pull request as draft August 21, 2024 01:19
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding EOC: Effects On Condition Anything concerning Effects On Condition Mods: Mind Over Matter astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 21, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 22, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review August 22, 2024 14:20
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 22, 2024
@Maleclypse Maleclypse merged commit 2851bdb into CleverRaven:master Aug 27, 2024
18 of 24 checks passed
@Standing-Storm Standing-Storm deleted the further-concentration-adjustments branch August 27, 2024 03:56
Knut-Aage-Hofseth pushed a commit to Knut-Aage-Hofseth/Cataclysm-DDA that referenced this pull request Aug 29, 2024
* Initial commit

* Buff master concentration

* Remove duplicates

* Reduce smoke penalties
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Mind Over Matter Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants