Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Signpost a way(denarius) to get to the forge of wonders #75837

Merged
merged 1 commit into from
Aug 31, 2024

Conversation

RenechCDDA
Copy link
Member

Summary

Content "Signpost a way(denarius) to get to the forge of wonders"

Purpose of change

The forge of wonders was made globally unique, but there's still no way to reliably find it.

Describe the solution

Thanks to Guardian's work to expose this the reveal and reveal route functions to EOCs, we can just write an EOC for it.

Describe alternatives you've considered

My original iteration had it firing on game start with this message:
{ "u_message": "When the troubles began, you felt something… new. You're not sure what it is, but you're sure you know how to get there. Somehow.", "type": "mixed" },

Testing

Works properly when used on the roads, gives magical prose hints when not on the roads as desired.

Additional context

Will not function properly without #75836 due to oter id matching (there is no spawned terrain with the id of road, it always spawns with a connection suffix)

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 19, 2024
@RenechCDDA RenechCDDA marked this pull request as ready for review August 30, 2024 12:02
@github-actions github-actions bot requested a review from KorGgenT August 30, 2024 12:03
@Maleclypse Maleclypse merged commit 0b709ec into CleverRaven:master Aug 31, 2024
35 of 41 checks passed
@RenechCDDA RenechCDDA deleted the forge_of_wonders_signpost branch August 31, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants