Prevent crash from -1 array idx when searching zones #75834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents a crash when searching for zones to add, but the search yields no results.
github-actions
bot
added
Info / User Interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Prevent crash from -1 array idx when searching zones"
Purpose of change
Bugfix for the bugfix in #75739 .
Describe the solution
Ok so this is embarrassing. #75739 was supposed to fix #75738 . It didn't. I don't know what I was thinking, the check should obviously be
>= 0and not>= -1because that was what it was supposed to prevent. I even recall testing it, but I must havecommit --amend:ed it somehow.Describe alternatives you've considered
Hiding in shame.
Testing
Yes. Now it does not crash. Promise!
Additional context