Some new reptiles

[Karol1223]

Summary

Content "A few new reptiles to populate the world"

Purpose of change

Reptile eggs exist but we have no reptiles that lay eggs. Also to make a bunch of foundations for myself to work off in TropiCata later.

Describe the solution

Rattlesnake changes

• Fear and anger triggers switched around. Being hurt should scare them, having a player on top of them should provoke an attack
• Made them slightly smaller. Snakelets significantly smaller
• Shorter gestation time (which shouldn't matter given their reproductive season is shorter than the timer anyway)
• Increased the aggression to where anger triggers actually matter
• Got CORNERED_FIGHTER
• Shortened their daylight vision
• Nerfed their health
• Removed their upgrades into mutants. I have been yapping endlessly about why this doesn't work for vertebrates. It would be nice if we could have a chance for reproduction to spawn a baby mutant instead, but not possible currently. See Allow baby_monster to support monstergroups #75830

New stuff

• Worm snake - the unmutated version of the sewer snake. Tiny, harmless, doesn't like light. How will the fear trigger affect it when it spawns in daylight? Who knows! (I do, it seems to not affect it at all when it has nowhere to flee from the light)
• Common garter snake - generic medium sized snake representative
• Five-lined skink - the only lizard native to the region
• Painted turtle
• Common snapping turtle

Other misc changes

• Obsoleted the generic reptile egg in favor of foraging specific reptile eggs instead
• TODO: Make new factions for the critters, so that snakes can actually hunt rats - POSTPONED! I'm gonna do a PR solely to split up small_animal in the future, but because I wanna do all of it at once, I abandon the idea of doing it here so as to not scope creep
• New requirement group for reptile eggs
• Updated TropiCata blacklist
• Tamable Wildlife changes - removed useless strings, removed adult rattlesnake taming, added all new reptiles to be tamable as babies

Describe alternatives you've considered

• Obsoleting the sewer snake - it's a weird really boring take on an actually interesting species of snake, but one that wouldn't be present in the sewer system. I intend to replace it, alongside seweranhas, with mutant leeches in the future - but for now they stay
• Including the diamondback terrapin in coastal spawns, but I don't actually know if we have coastal wilderness spawns? I know we have coastal spawns in the water, but not sure about beaches
• Giving turtles a special attack that'd imitate withdrawing inside the shell - entirely pointless for most non-mutant turtles that we're simulating, not viable either because monsters never lose aggro so they'd just keep poking the shell indefinitely
• Making snapping turtles basically blind to imitate them being patient hunters - turns out common snappers are actualy active hunters and move around to hunt prey? That was new to me

Testing

Additional context

Known issue:

• The snakes have aggression above 10, and even though they won't go out of their way to attack the player due to aggro_character: false, they still trigger safemode. I need the aggression to be above 10 for future faction shenanigans to allow them to hunt rodents and the such, but I do not know any way to have them be ignored by safemode while keeping their aggression above 10

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• common snaping turtle
• common snaping turtles

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.