-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MoM] Convert Lifting Hand to power, give Telekinetics a new passive #75816
Merged
Maleclypse
merged 19 commits into
CleverRaven:master
from
Standing-Storm:lifting-hand-to-power
Aug 22, 2024
Merged
[MoM] Convert Lifting Hand to power, give Telekinetics a new passive #75816
Maleclypse
merged 19 commits into
CleverRaven:master
from
Standing-Storm:lifting-hand-to-power
Aug 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
<Documentation>
Design documents, internal info, guides and help.
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
[Markdown]
Markdown issues and PRs
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Mind Over Matter
labels
Aug 19, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Aug 19, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
Crafting / Construction / Recipes
Includes: Uncrafting / Disassembling
<Documentation>
Design documents, internal info, guides and help.
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
[Markdown]
Markdown issues and PRs
Mods: Mind Over Matter
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[MoM] Convert Lifting Hand to power, give Telekinetics a new passive"
Purpose of change
My original idea was to make Lifting Field a power (it's extremely powerful for a passive ability), but I was hampered by a bug that deleted everything in an integrated container when the container was removed. #75565 fixed that bug, allowing me to switch Lifting Field to its intended implementation.
Describe the solution
Convert Lifting Field to a power, including documentation, learning EoCs, contemplation recipes, and so on. Include an update EoC that converts existing characters over and gives them the appropriate level of Lifting Field.
Replace it as the passive with Grasping Hand, which reduces time to pull items from pockets or containers by 10% + 0.075% per Telekinesis power level.
Describe alternatives you've considered
Testing
The conversion EoC works, removing the Lifting Field recipe and adding the power and concentration recipe. Awakening, taking a hobby, or taking the profession start you with Grasping Hand. The learning EoC triggers, grants the recipe, and the power can be learned. Contemplating it further grants XP to the power. When used, the Lifting Field appears, and when concentration ends it disappears. Maintaining the power grants XP correctly.
Additional context