Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit the remaining vanilla birds #75779

Merged
merged 38 commits into from
Aug 22, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

@Karol1223 Karol1223 commented Aug 17, 2024

Summary

None

Purpose of change

Follow up to #73087, it's time to finish the job

Describe the solution

Affected stinkers:

  • Chicken
  • Grouse -> Ruffed Grouse
  • Duck -> Mallard
  • (New) Domestic Duck
  • Turkey -> Wild Turkey
  • (New) Domestic Turkey
  • Pheasant -> Ring-necked Pheasant
  • Goose -> Canada Goose
  • Goose -> Domestic Goose
  • OBSOLETE Golden Honker
  • Woodpecker -> Downy Woodpecker
  • Grebe -> Horned Grebe
  • Coot -> American Coot
  • Moorhen -> Common Gallinule
  • Hummingbird -> Ruby-throated Hummingbird
  • Cormorant -> Double-crested Cormorant

Other notes:

  • A bunch of new abstracts to make the job easier
  • Corrected the egg requirement group egg amounts for the smallest fellows
  • HP revisions in accordance to my new HP calculation method
  • I also went and audited the spawns for domestic bird species. Chickens should no longer be brought back from camp hunting results, but other than that the spawnpools for old birds should be relatively similar.
  • All affected birds primarily had the names, sizes, and reproduction reviewed. Movement speed was also slightly modified
  • The most notable here is likely the chicken which had a near 50% size decrease, as our chickens had their weight based off broilers in good condition. They're likely still too big currently, but I'm feeling generous
  • Likely also worth noting is the fact that Canada goose is no longer tamable as a chick. This interaction is moved to Tamable Wildlife
  • As per the discussion under Bird Audit - Passerines #73087, I also removed the taming of aggressive/skittish birds from Tamable Wildlife when adult. This included the woodpecker, coot, gallinule, grebe, cormorant, and Canada goose. I also removed more unused CANPLAY flags and added the grouse chick to be tameable, as the species was completely missed in the mod.

Describe alternatives you've considered

TODO in future PRs:

  • Group the different types of birds inside mongroups for easier management, adding new birds, and moddability
  • Review the mutant corvids
  • Make some new monster factions for the birdies
  • Replace generic bird egg spawns with different actual bird eggs

Testing

Additional context

Almost all information obtained either from wikipedia or animaldiversity.org

The reproduction timer is the sum of egg hatch time and the time it takes for the young to fledge (or if found, time to reach independence)

The universe would be so much better if we had an automatic calculator for egg volume from length and width data. Seriously, why does that not exist. Any excel wizards wanna give it a shot?

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Monsters Monsters both friendly and unfriendly. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 17, 2024
@github-actions github-actions bot added the Spawn Creatures, items, vehicles, locations appearing on map label Aug 17, 2024
@github-actions github-actions bot added Mods Issues related to mods or modding Mods: Tamable Wildlife labels Aug 18, 2024
@Karol1223 Karol1223 marked this pull request as ready for review August 18, 2024 10:05
@github-actions github-actions bot added the Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. label Aug 18, 2024
@DukePaulAtreid3s
Copy link
Contributor

Would you consider making the Golden Honker a very rare mutation of the Canada Goose?

@Karol1223
Copy link
Contributor Author

Karol1223 commented Aug 18, 2024

Would you consider making the Golden Honker a very rare mutation of the Canada Goose?

No, because it really isn't fitting or interesting in any way. Physically it's a """more regal""" whatever that means domestic goose, that just happens to lay bigger eggs. It's not something worth preserving in my eyes. It's a joke monster that's not even funny, just weird.

I believe it was made to try and add something similar to the Golden Chonker, the cat, and that guy's on my shitlist as well albeit for different reasons (an obese cat makes sense, but why the fuck is it genetic and the kittens are also obese when they grow up?)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 18, 2024
@Maleclypse Maleclypse merged commit ab77a1f into CleverRaven:master Aug 22, 2024
23 of 24 checks passed
@Karol1223 Karol1223 deleted the vanilla-birdie branch August 23, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods: TropiCataclysm 🌴 Having to do with the tropical region mod for DDA. Mods Issues related to mods or modding Monsters Monsters both friendly and unfriendly. Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants