Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enchantments can affect monster luminance #75768

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Another request from discord

Describe the solution

LUMINATION enchantment now can affect monsters

Testing

  {
    "type": "effect_on_condition",
    "id": "EOC_TEST_APPLY_EFFECT",
    "eoc_type": "EVENT",
    "required_event": "character_melee_attacks_monster",
    "effect": [ { "npc_add_effect": "effect_test_test", "duration": 9999 }, { "u_message": "Applied lumination" } ]
  },
  {
    "id": "effect_test_test",
    "type": "effect_type",
    "name": [ "AAAAA" ],
    "desc": [ "AAAAA." ],
    "rating": "good",
    "show_intensity": true,
    "enchantments": [ { "values": [ { "value": "LUMINATION", "add": 40 } ] } ]
  }

image

Additional context

@Standing-Storm

@github-actions github-actions bot requested a review from KorGgenT August 17, 2024 09:54
@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 17, 2024
@RedMisao
Copy link
Contributor

Yesss now monsters will burn in the dark

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 17, 2024
@Maleclypse Maleclypse merged commit 8c9b675 into CleverRaven:master Aug 18, 2024
27 of 28 checks passed
@Standing-Storm
Copy link
Contributor

Multiple applications for this including vanilla (insect mutants spit their goop onto a monster!)

@GuardianDll GuardianDll deleted the mon_lumination branch August 18, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants