Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tamable Wildlife] Allow the taming of chicks #75766

Merged
merged 1 commit into from
Aug 18, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

The mod allowed the taming of adult birds, but not the chicks. This is likely because in the past, all the wild chicks were tamable in vanilla. But they no longer are, and now even with the mod they can't be tamed until they grow to adulthood.

Describe the solution

  • Add overrides for those chicks that aren't tamable in vanilla but their adults are tamable in the mod
  • Remove useless CANPLAY flags on birds that already have this flag in vanilla

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Tamable Wildlife astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 17, 2024
Copy link
Contributor

@Termineitor244 Termineitor244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, Github was supposed to notify me for changes in the mod files, weird it didn't happen...

And thanks for the help! I'm actually playing in a save where I was planning to tame the chicks I found in the city, so I was going to have a big surprise hahaha.

All changes look good to me!

@Karol1223
Copy link
Contributor Author

Huh, Github was supposed to notify me for changes in the mod files, weird it didn't happen...

The auto request reviewer action is broken and is failing randomly. It works like 50% of the time nowadays.

@Termineitor244
Copy link
Contributor

Huh, Github was supposed to notify me for changes in the mod files, weird it didn't happen...

The auto request reviewer action is broken and is failing randomly. It works like 50% of the time nowadays.

Oh shoot, well, that explains it, I was not aware of that haha.

@Maleclypse Maleclypse merged commit 747f013 into CleverRaven:master Aug 18, 2024
25 of 26 checks passed
@Karol1223 Karol1223 deleted the tamable-birdies branch August 18, 2024 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Tamable Wildlife Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants