Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow cephalopods to gain the ability to eat, sleep underwater #75764

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Allow cephalopods to gain the ability to eat, sleep underwater #75764

merged 1 commit into from
Aug 18, 2024

Conversation

Psithief
Copy link
Contributor

@Psithief Psithief commented Aug 17, 2024

Summary

Features "Allow cephalopods to gain the ability to eat, sleep underwater"

Purpose of change

I thought it was strange that fish mutants and frog mutants could eat underwater but a cephalopod mutant could not. I didn't really care about sleeping.

Describe the solution

This modifies the Aqueos Sleeper trait to also be in the Cephalopod mutation tree, requiring the threshold and the Cephalopod Gills mutation.

Describe alternatives you've considered

I considered requiring the Cephalopod Eyes mutation instead. I don't understand why this mutation requires the eye mutations and not the breathing underwater mutations.

Testing

I tested loading a game to make sure there were no JSON errors.
I tested using the debug menu to grant the mutation to a character with the THRESH_CEPHALOPOD and GILLS_CEPH mutations.

Additional context

If merged, will data/mods/extra_mut_scen/mutation_scenarios.json need to be updated as well?

@Psithief Psithief changed the title Allow cephalopods to eat, sleep underwater Allow cephalopods to gain the ability to eat, sleep underwater Aug 17, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies new contributor <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 17, 2024
@Maleclypse Maleclypse merged commit dd38058 into CleverRaven:master Aug 18, 2024
29 checks passed
@Maleclypse
Copy link
Member

Thanks for your contribution!

@Psithief Psithief deleted the patch-2 branch August 18, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants