Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monster vision enchantment and evaluation #75753

Merged
merged 3 commits into from
Aug 18, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Request from discord

Describe the solution

Add monster enchantment, that affects monster vision range
Update vision_range_eval to return vision range of monster also

Testing

  {
    "type": "effect_on_condition",
    "id": "EOC_TEST_APPLY_EFFECT",
    "eoc_type": "EVENT",
    "required_event": "character_melee_attacks_monster",
    "effect": [
      { "math": [ "_a", "=", "n_vision_range()" ] },
      { "npc_add_effect": "effect_test_test", "duration": 9999 },
      { "u_message": "monster vision range: <context_val:a>" }
    ]
  },
  {
    "id": "effect_test_test",
    "type": "effect_type",
    "name": [ "AAAAA" ],
    "desc": [ "AAAAA." ],
    "rating": "good",
    "show_intensity": true,
    "enchantments": [ { "values": [ { "value": "VISION_RANGE", "add": 5 } ] } ]
  }

image
"enchantments": [ { "values": [ { "value": "VISION_RANGE", "multiply": 0.5 } ] } ]
image
"enchantments": [ { "values": [ { "value": "VISION_RANGE", "multiply": -0.5 } ] } ]
image

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` Monsters Monsters both friendly and unfriendly. [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 16, 2024
@dseguin dseguin merged commit 56dd3fc into CleverRaven:master Aug 18, 2024
24 of 25 checks passed
@GuardianDll GuardianDll deleted the mon_vis_stuff branch August 18, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs Mechanics: Enchantments / Spells Enchantments and spells Monsters Monsters both friendly and unfriendly. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants