Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Update Restore Genetic Stability biomancer spell for new MUT_INSTABILITY_MOD effect #75746

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Aug 16, 2024

Summary

Mods "[Magiclysm] Update Restore Genetic Stability biomancer spell for new MUT_INSTABILITY_MOD effect"

Purpose of change

Instability isn't a vitamin anymore.

Describe the solution

Change the spell's name to "Preserve Genetic Stability"

The spell now makes it so that you have 1 fewer good mutation (-1 per 5 spell levels) when calculating your odds of bad mutations. Text changed to reflect this.

Describe alternatives you've considered

Testing

Additional context

Biomancers and druids can have separate niches--druids can shapechange (but the form is set and they can only pick the form, not the capabilities of that form) and biomancers are better at mutating.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod Mechanics: Enchantments / Spells Enchantments and spells labels Aug 16, 2024
@github-actions github-actions bot requested a review from KorGgenT August 16, 2024 17:12
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 16, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • The scroll said that this spell is for "Reducing negative consequencse from XE037 exposure", whatever that means. According the scroll, the spell should be allowed to run its course before reapplication.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 17, 2024
@Maleclypse Maleclypse merged commit 4e4419c into CleverRaven:master Aug 18, 2024
25 checks passed
@Standing-Storm Standing-Storm deleted the fix-biomancer-mutations branch August 18, 2024 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants