Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neverending problems with disassembly #75722

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

  • Corrected the resources obtained from disassembling both quilt types - the uncraft was losing LOTS of resources for some reason. And for some reason, the patchwork quilt defaulted to giving gambeson batting instead of cotton balls?
  • Added an uncraft for portable soldering irons that give resources from both normal soldering iron disassembly and the ones needed to craft them into the portable version. This might generate mass, but I am not too worried about this with electronic recipes - the weights there are all over the place anyway due to our resources being generified
  • Turned the copper hatchet into a very simple uncraft/reversion integration so it doesn't need a hotplate to take apart
  • Threw out the uncrafts for scrap boots and armguards, as 3/4 of them were transmuting cordage into scrap steel. Instead now they're reversible recipes with manually defined time
  • Defined the uncraft time for tire armguards to be 10 mins instead of letting them default to 45 mins

Describe the solution

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 15, 2024
@Maleclypse Maleclypse merged commit 24633f5 into CleverRaven:master Aug 22, 2024
24 of 26 checks passed
@Karol1223 Karol1223 deleted the let-them-eat-disassembly branch August 22, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants