Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sky Island] Add Warped Pond craft #75713

Merged
merged 7 commits into from
Aug 16, 2024

Conversation

Standing-Storm
Copy link
Contributor

Summary

Mods "[Sky Island] Add Warped Pond craft"

Purpose of change

Been meaning to do this for months, and more ways to decorate your island are good.

Describe the solution

Create a crafting recipe that creates a pond on your island. It takes 30 warp shards and requires that you have a water tile nearby (so you can only create a pond when you've already secured a source of infinite water). The craft requires that you select a water tile and, when doing so, you can place the pond to the NW, NE, SW, or SE (so it's not on top of any part of the bunker). The pond's appearance is slightly random.

Describe alternatives you've considered

Testing

Recipe works. If you cannot select a water tile, the warp shard cost is refunded. The menu to pick a location pops up and all locations are correct. The pond appears.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Missions Quests and missions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved Mods: Sky Island Anything about the Sky Island mod labels Aug 15, 2024
@github-actions github-actions bot requested a review from Maleclypse August 15, 2024 15:10
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 15, 2024
@Maleclypse Maleclypse merged commit a0bc244 into CleverRaven:master Aug 16, 2024
24 checks passed
@Naadn
Copy link
Contributor

Naadn commented Aug 17, 2024

Could the water well/water pump be count as a source of infinite water for EoC? I would like have pond on island but don't want 1 single ugly water tile to ruined the scenery.

@Standing-Storm Standing-Storm deleted the sky-island-pond branch August 18, 2024 03:44
@Standing-Storm
Copy link
Contributor Author

Ugly? :(

it should be possible to check for either a water pump or a water tile. I’m away from home now but can get to it in a couple days.

@Naadn
Copy link
Contributor

Naadn commented Aug 18, 2024

Ugly? :(

I mean a single, square water tile away from the rest, cause it need to be near the statue

@Standing-Storm
Copy link
Contributor Author

Standing-Storm commented Aug 18, 2024

It's not just the statue, it's the warp obelisk too, and you can drag that wherever you want IIRC.

It's still a good idea to include wells and pumps since they're also infinite water sources though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Crafting / Construction / Recipes Includes: Uncrafting / Disassembling EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Missions Quests and missions Mods: Sky Island Anything about the Sky Island mod Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants