Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow speech to be relearnt in the dark #75710

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Allow speech to be relearnt in the dark #75710

merged 1 commit into from
Aug 18, 2024

Conversation

Psithief
Copy link
Contributor

@Psithief Psithief commented Aug 15, 2024

Summary

Bugfixes "Recipes: Allow speech to be relearnt in the dark"

Purpose of change

This allows the "unmute" practise recipes to be trained in the dark.
A character does not need sight to practise speaking and these recipes do not require a mirror.

Describe the solution

Adds the "BLIND_EASY" flag to these recipes.

Describe alternatives you've considered

I know of no other solution.

Testing

I tested recipe prac_unmute_ceph in the dark. The edits to the other recipes are identical.

Additional context

Fixes oversight in #74165

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Bugfix> This is a fix for a bug (or closes open issue) new contributor astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 15, 2024
@Psithief
Copy link
Contributor Author

Requesting PR Validator re-run.

@Maleclypse
Copy link
Member

Requesting PR Validator re-run.

Before requesting a test be rerun you should look at the error and see if it is your fault. It is.

Error: Please fix your PR SUMMARY line to match (\n|^)#### Summary\s+`{0,3}(SUMMARY:\s+)?(None|((Features|Content|Interface|Mods|Balance|Bugfixes|Performance|Infrastructure|Build|I18N) +".+"))`{0,3}\s*(\n|$)
Bugfix "Recipes: Allow speech to be relearnt in the dark"

Corrected Summary

Bugfixes "Recipes: Allow speech to be relearnt in the dark"

I'll fix it for you.

@Maleclypse
Copy link
Member

Once the test runs I'll merge this. Thanks for your contribution!

@Maleclypse Maleclypse merged commit b89f92a into CleverRaven:master Aug 18, 2024
26 of 31 checks passed
@Psithief Psithief deleted the Psithief-patch-1 branch August 18, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants