Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You can order weapons from an artisan blacksmith #75702

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Uwuewsky
Copy link
Contributor

Summary

Features "Cody has a new dialogue where you can order weapons"

Purpose of change

The blacksmith could create armor for the player, but not weapons.

Describe the solution

Adds a dialogue branch similar to the armor dialogue. The assortment is based on the itemgroup of trade weapons, plus a couple of short blades to fill the niche. Price and waiting time are based on the same values ​​for the armor. Weapons are cheaper and faster to produce.
23 hours with all the necessary proficiencies and 8 skill (the blacksmith has a skill 7-10) which gives a full 3-4 days:
sword_tempered

Describe alternatives you've considered

Any suggestions regarding price/time or dialogue lines are greatly appreciated.

Testing

Test world with completed quest: Test-trimmed.tar.gz

Screenshots

wpn2
wpn3
wpn6
wpn8
wpn9

Additional context

Buying with a wait time is used in many places, wouldn't it be nice to have a separate trade menu for this instead of using dialogs?
"u_has_var" can't check for existence of variable with any value? "math" can't be used with strings?

@Uwuewsky Uwuewsky changed the title You can order weapons from a artisan blacksmith You can order weapons from an artisan blacksmith Aug 15, 2024
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON <Enhancement / Feature> New features, or enhancements on existing labels Aug 15, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • [250 merch, 4 days] I need a zweihander.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 15, 2024
@Maleclypse Maleclypse merged commit bc8c2df into CleverRaven:master Sep 6, 2024
21 of 27 checks passed
@Uwuewsky Uwuewsky deleted the cody_weapon branch September 7, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants