Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baseball bat recipe #75693

Merged
merged 18 commits into from
Oct 1, 2024
Merged

Conversation

bloodbowel
Copy link
Contributor

Summary

Features "Adds a baseball bat recipe"

Purpose of change

You can't make a baseball bat in the game. It shouldn't be too hard to do for someone with some basic tools.

Describe the solution

1.Add a recipe for a baseball bat. See the image for details.
2.Remove the reference to a plastic handle on baseball bats. You don't need one.

I thought these were treated and was going to add a soaking period but apparently not.

Describe alternatives you've considered

Maybe some additional tools should be required?

Testing

Tested on my computer in debug mode.

Additional context

Screenshot

@github-actions github-actions bot added <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON astyled astyled PR, label is assigned by github actions labels Aug 15, 2024
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • A sturdy wooden bat used to play the great american pastime. Makes for a great melee weapon too.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

bloodbowel and others added 2 commits August 14, 2024 22:16
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 15, 2024
data/json/recipes/weapon/bashing.json Outdated Show resolved Hide resolved
Co-authored-by: Karol1223 <[email protected]>
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 15, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 21, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 28, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Sep 5, 2024
@x-qq
Copy link

x-qq commented Sep 9, 2024

I think this recipe needs filing 1 (= require sandpaper), include flame treatment for durability (= require fire) and require wood cutting 2. Real bats also undergo some sort of chemical treatment but I'm not sure how to represent it here.

Reference: https://www.youtube.com/watch?v=zwK4qdbWwdw

@bloodbowel
Copy link
Contributor Author

I think this recipe needs filing 1 (= require sandpaper), include flame treatment for durability (= require fire) and require wood cutting 2. Real bats also undergo some sort of chemical treatment but I'm not sure how to represent it here.

I've been doing some research to parse out what is the best way to treat the bat. Originally I was going to have it be soaked like a spear shaft, but saw they didn't all do this. Not all are flame tempered either. The oldest method is bone rubbing which is just pressing it down with a hard object. This probably should require better tools including actual files.

@Maleclypse
Copy link
Member

Yeah go ahead and add either sand paper or wood filing or both as you see fit and this is mergeable.

@bloodbowel
Copy link
Contributor Author

I added the level 1 file. That should be good enough.

@Night-Pryanik Night-Pryanik merged commit af73fb5 into CleverRaven:master Oct 1, 2024
24 checks passed
@bloodbowel bloodbowel deleted the baseball-bat-recipe branch October 1, 2024 21:56
@Brambor
Copy link
Contributor

Brambor commented Oct 2, 2024

Looking at the commit history, this PR should have been git merge --squashed, if the GitHub interface allows it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants