Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make uilist menus render their footer text/item descriptions with color #75684

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

db48x
Copy link
Contributor

@db48x db48x commented Aug 14, 2024

Summary

Interface "make uilist menus render their footer text/item descriptions with color"

Purpose of change

Makes the uilist menus render their footer text/item descriptions with color, if they happen to use color tags. This fixes #75673

Testing

The easiest place to see it is the would care menu you get when you consume a bandage or some antiseptic.

@db48x
Copy link
Contributor Author

db48x commented Aug 14, 2024

This fixes #75673

@GuardianDll
Copy link
Member

fixes #75673 works only when in the PR body

@github-actions github-actions bot added the Info / User Interface Game - player communication, menus, etc. label Aug 14, 2024
@db48x
Copy link
Contributor Author

db48x commented Aug 14, 2024

It’s in the commit message too, which I think works. Anyway, I can always close the issue by hand if needed. Now to wait for the build, which takes ages.

@github-actions github-actions bot added the [C++] Changes (can be) made in C++. Previously named `Code` label Aug 14, 2024
@ZhilkinSerg
Copy link
Contributor

Seems to be working:

image

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 14, 2024
@db48x
Copy link
Contributor Author

db48x commented Aug 15, 2024

What’s up with the build today? Usually there is at least an error message from the compiler, but it just says “This job failed”. Not very helpful.

@Maleclypse
Copy link
Member

Maleclypse commented Aug 15, 2024

What’s up with the build today? Usually there is at least an error message from the compiler, but it just says “This job failed”. Not very helpful.

We ran out of github bandwidth and it stopped tests until we were back under the freemium usage allowances. (I think based on some other things I saw today)

@db48x
Copy link
Contributor Author

db48x commented Aug 15, 2024

Oh, nice. Such helpful error messages GitHub has!

@akrieger akrieger merged commit dccf622 into CleverRaven:master Aug 15, 2024
21 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ImGui uilist menus render their footer text without color tags
5 participants