Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose new faction values to math #75672

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

GuardianDll
Copy link
Member

Summary

None

Purpose of change

Close #75082

Describe the solution

Expose values to math

Testing

  {
    "type": "effect_on_condition",
    "id": "Test_EOC",
    "effect": [
      { "math": [ "_aa", "=", "faction_food_supply('free_merchants')" ] },
      { "math": [ "_bb", "=", "faction_wealth('free_merchants')" ] },
      { "math": [ "_cc", "=", "faction_power('free_merchants')" ] },
      { "math": [ "_dd", "=", "faction_size('free_merchants')" ] },
      { "u_message": "faction_food_supply('free_merchants'): <context_val:aa>" },
      { "u_message": "faction_wealth('free_merchants'): <context_val:bb>" },
      { "u_message": "faction_power('free_merchants'): <context_val:cc>" },
      { "u_message": "faction_size('free_merchants'): <context_val:dd>" },
      { "math": [ "faction_food_supply('free_merchants')", "=", "123456" ] },
      { "math": [ "faction_wealth('free_merchants')", "=", "12" ] },
      { "math": [ "faction_power('free_merchants')", "=", "34" ] },
      { "math": [ "faction_size('free_merchants')", "=", "56" ] },
      { "u_message": "--------------\n--------------\n--------------\n--------------\n" },
      { "math": [ "_aa", "=", "faction_food_supply('free_merchants')" ] },
      { "math": [ "_bb", "=", "faction_wealth('free_merchants')" ] },
      { "math": [ "_cc", "=", "faction_power('free_merchants')" ] },
      { "math": [ "_dd", "=", "faction_size('free_merchants')" ] },
      { "u_message": "faction_food_supply('free_merchants'): <context_val:aa>" },
      { "u_message": "faction_wealth('free_merchants'): <context_val:bb>" },
      { "u_message": "faction_power('free_merchants'): <context_val:cc>" },
      { "u_message": "faction_size('free_merchants'): <context_val:dd>" }
    ]
  }

image
image

@GuardianDll GuardianDll force-pushed the new_faction_values_math branch from 6804faf to fa1e5c7 Compare August 14, 2024 18:11
@github-actions github-actions bot added <Bugfix> This is a fix for a bug (or closes open issue) <Documentation> Design documents, internal info, guides and help. NPC / Factions NPCs, AI, Speech, Factions, Ownership [C++] Changes (can be) made in C++. Previously named `Code` [Markdown] Markdown issues and PRs astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 14, 2024
@Maleclypse Maleclypse merged commit 1a7ed3e into CleverRaven:master Aug 15, 2024
21 of 26 checks passed
@GuardianDll GuardianDll deleted the new_faction_values_math branch August 15, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow various NPC faction statistics to be edited with math and EOCs
2 participants