Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vision granularity audit: Military (or just FEMA Camps) #75645

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

sonphantrung
Copy link
Contributor

@sonphantrung sonphantrung commented Aug 13, 2024

Summary

Content "Add more vision level (at least for FEMA camps, for now)"

Purpose of change

I find it strange how a building with multiple tents is treated the same as a concrete building.

Describe the solution

Added a new overmap terrain vision called isolated_camp (sure, there are body sites there, but mostly the thing that stands out most are tents)

Describe alternatives you've considered

Leave it as is

Testing

Tested w/ a FEMA refugee camp:
image
image

Additional context

I'll do more later on, this is just the beginning

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Aug 13, 2024
@Maleclypse Maleclypse merged commit f220861 into CleverRaven:master Aug 15, 2024
26 of 27 checks passed
@sonphantrung sonphantrung deleted the diverse-granularity branch August 22, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants