Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finishing the spear shaft recipe #75640

Merged
merged 29 commits into from
Nov 29, 2024

Conversation

bloodbowel
Copy link
Contributor

Summary

Features "Adds a soaking spear shaft"

Purpose of change

I was going to create a recipe for a weapon based on the one for a spear shaft. While I was examining it I noticed the recipe was not done.

Describe the solution

I decided to add a soaking spear shaft which becomes a regular spear shaft after 4 hours in oil.

Describe alternatives you've considered

Your characters watch oil dry for 4 hours. I think this is what was intended or at least close enough. The "to hit" is jerry rigged with the current mechanics to be lower because it's slick. I don't think you can just put minus to-hit. Is there a better way to simulate a weapon being slimy? I would have it even lower than that maybe.

Testing

Tested on my computer in debug mode.

Additional context

Screenshot4

add the soaking spear shaft item
the spear shaft recipe makes a soaking spear shaft now
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions labels Aug 13, 2024
bloodbowel and others added 4 commits August 13, 2024 16:39
grip goes from none to bad

Co-authored-by: TheShadowFerret <[email protected]>
remove extra space

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
balance from neutral to good
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Aug 13, 2024
Copy link

@x-qq x-qq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.

@Maleclypse
Copy link
Member

(~[slow] [.],starting_items)=> ../tests/effective_dps_test.cpp:312: FAILED:
(
[slow] [.],starting_items)=> CHECK( calc_expected_dps( it->get_id() ) <= 5.0 )
(
[slow] [.],starting_items)=> with expansion:
Error: (
[slow] [.],starting_items)=> Approx( 5.9192240565 ) <= 5.0
(
[slow] [.],starting_items)=> with message:
(
[slow] [.],starting_items)=> 'soaking_spear_shaft' is a weapon, but is not included in DPS tests. Please
(
[slow] [.],starting_items)=> place it in the appropriate file in data/mods/TEST_DATA/expected_dps_data.
(
[slow] ~[.],starting_items)=>

@github-actions github-actions bot added the Code: Tests Measurement, self-control, statistics, balancing. label Oct 6, 2024
@bloodbowel
Copy link
Contributor Author

It's failed to build now. Is this right? Am I missing something?

@Night-Pryanik
Copy link
Contributor

Your change broke the tests, see failed build error message.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Nov 13, 2024
@Night-Pryanik Night-Pryanik merged commit 4043064 into CleverRaven:master Nov 29, 2024
17 of 23 checks passed
@bloodbowel bloodbowel deleted the finish-spear-shaft-recipe branch November 29, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants