Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardened convict profession #75639

Merged
merged 13 commits into from
Sep 10, 2024
Merged

Conversation

bloodbowel
Copy link
Contributor

Summary

Features "Nerf the convict and add a hardened convict"

Purpose of change

A lot of convicts are just boring ordinary people. The convict profession and prison scenarios only give you a tough guy and some interesting characters though.

Describe the solution

I made a generic convict with no shiv or weapon knowledge. Then gave those to a new profession called a hardened convict.

Describe alternatives you've considered

It seems pretty uncontroversial to me. Can't think of any reason not to do it.

Testing

Tested it on my computer in a regular game.

Additional context

Screenshot

removes the convicts skills, proficiencies, and shiv and adds a hardened convict with those
adds the hardened convict option to the prison scenarios
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios <Enhancement / Feature> New features, or enhancements on existing astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 13, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 19, 2024
@github-actions github-actions bot removed the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 24, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 25, 2024
@Maleclypse Maleclypse merged commit 072c3f2 into CleverRaven:master Sep 10, 2024
24 checks passed
@bloodbowel bloodbowel deleted the hardened-convict branch September 11, 2024 03:52
@ghost ghost mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Enhancement / Feature> New features, or enhancements on existing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Scenarios New Scenarios, balancing, bugs with scenarios
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants