-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardened convict profession #75639
Merged
Merged
Hardened convict profession #75639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removes the convicts skills, proficiencies, and shiv and adds a hardened convict with those
adds the hardened convict option to the prison scenarios
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Scenarios
New Scenarios, balancing, bugs with scenarios
<Enhancement / Feature>
New features, or enhancements on existing
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Aug 13, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 19, 2024
github-actions
bot
removed
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 24, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Aug 25, 2024
ghost
mentioned this pull request
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
<Enhancement / Feature>
New features, or enhancements on existing
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Scenarios
New Scenarios, balancing, bugs with scenarios
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Features "Nerf the convict and add a hardened convict"
Purpose of change
A lot of convicts are just boring ordinary people. The convict profession and prison scenarios only give you a tough guy and some interesting characters though.
Describe the solution
I made a generic convict with no shiv or weapon knowledge. Then gave those to a new profession called a hardened convict.
Describe alternatives you've considered
It seems pretty uncontroversial to me. Can't think of any reason not to do it.
Testing
Tested it on my computer in a regular game.
Additional context