Fix dereference into an empty container #75630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was somehow only crashing on LTO builds
github-actions
bot
added
Items: Battery / UPS
github-actions
bot
added
the
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
A bad assumption on my part that itype::src was always populated by at least "dda" led to attempting to derference an empty container, causing a crash, but somehow only with LTO builds.
Describe the solution
Check for container population before dereferencing.
Testing
It's only exercised in the test, so just need the tests to run to completion.
I reproduced and tested with a LTO build locally, hopefully that makes the g++9 build happy again, requires #75576 to be merged as well or it will hit the OTHER LTO-specific breakage.