Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flathub download button and Flatpak manifest #75625

Merged
merged 4 commits into from
Aug 13, 2024

Conversation

grisha765
Copy link
Contributor

@grisha765 grisha765 commented Aug 12, 2024

Summary

Infrastructure "Add Flathub download button and Flatpak manifest"

Purpose of change

To make it easier for users to download the game via Flathub, I have added a download button that directs users to the Flathub page. Additionally, I included a Flatpak manifest (yaml) in the repository to facilitate the building and distribution of the game via Flatpak.

Describe the solution

  • Added a "Download on Flathub" button in README.md.
  • Created a Flatpak manifest (yaml) file and added it to the repository, allowing the game to be easily packaged and distributed via Flatpak.

Describe alternatives you've considered

I considered creating a separate repository specifically for the Flatpak version of the game, but ultimately decided to submit it to Flathub to leverage its existing infrastructure and reach a wider audience.

Testing

  • Verified that the Flathub download button correctly links to the Flathub page.
  • Tested the Flatpak manifest by building the package locally to ensure it works as expected.

Additional context

N/A

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [Markdown] Markdown issues and PRs Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Aug 12, 2024
@kevingranade
Copy link
Member

That's fine but need to reign in that badge size, it's pretty egregiously overstating the prominence of flathub.

@grisha765
Copy link
Contributor Author

grisha765 commented Aug 12, 2024

That's fine but need to reign in that badge size, it's pretty egregiously overstating the prominence of flathub.

I'll make it smaller

README.md Outdated Show resolved Hide resolved
Copy link
Member

@kevingranade kevingranade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, sorry to be picky about the badge but it feels like advertising for flatpack at some point instead of just offering an option.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 13, 2024
@akrieger
Copy link
Member

So to update the flathub download, we have to update the commit hash in the manifest?

@akrieger
Copy link
Member

I see, it's currently pointing to 0.G.

@akrieger akrieger merged commit 4bf90cd into CleverRaven:master Aug 13, 2024
15 of 20 checks passed
@grisha765 grisha765 deleted the new-br branch August 13, 2024 23:52
@Raikiri
Copy link

Raikiri commented Aug 16, 2024

does it make sense to have an autoupdating experimental version?

@grisha765
Copy link
Contributor Author

does it make sense to have an autoupdating experimental version?

in the beta branch I try to upload the latest experimental version every Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style <Documentation> Design documents, internal info, guides and help. json-styled JSON lint passed, label assigned by github actions [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants