Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove XS/XXXL traits from the player display #75612

Conversation

bloodbowel
Copy link
Contributor

Summary

Interface "Removes XS/XXXL traits from the player display"

Purpose of change

If you start with the XXXL or XS trait it will remain on your list of character traits permanently. This becomes inaccurate if you lose or gain weight.

Describe the solution

Remove the traits from the players display and use the weight indicator to show their effect.

Describe alternatives you've considered

The game could track your weight and remove these at a certain threshold. Maybe the traits themselves could also be renamed to "Morbidly Obese" and "Near Starving" to make it more clear. The traits don't effect clothing size anyway.

Testing

Tested on my computer in a regular game.

xs and xxxl traits removed from the player display
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies Info / User Interface Game - player communication, menus, etc. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Aug 12, 2024
@Maleclypse Maleclypse merged commit b4fa234 into CleverRaven:master Aug 12, 2024
20 of 25 checks passed
@Maleclypse
Copy link
Member

Good catch!

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Aug 12, 2024
@bloodbowel bloodbowel deleted the make-xs/xxxl-traits-not-visible-in-game branch August 12, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Info / User Interface Game - player communication, menus, etc. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mutations / Traits / Professions/ Hobbies Mutations / Traits / Professions/ Hobbies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants