Fixed getting min/max drop values from deconstruction when modifier is NULL #75325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Wrong information on furniture deconstruction"
Purpose of change
Fixes #75308
Function
Single_item_creator::every_item_min_max()
usedmodifier->count
to get min/max amount of items you get from deconstruction.Since modifier is
std::optional
it is not always providedDescribe the solution
Check if
modifier
is not NULL. If it is - we return [1,1] if item drop chance is 100 and [0,1] if it is less.Describe alternatives you've considered
None
Testing
Tried to deconstruct
heavy machinery
and got perfect resultsAdditional context