Provide insertion failure reasons from only eligible pockets #75304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to insert "plastic painkiller bottle" into a full backpack, the failure reason was previously shown as "item is too short". This commit instead makes the failure reason only show from pockets that could possibly contain the item. In effect, the failure reason when inserting "plastic painkiller bottle" into a full backpack will now instead be "not enough space".
github-actions
bot
added
[C++]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Provide insertion failure reasons from only eligible pockets"
Purpose of change
Display "not enough space" instead of "item is too short" when trying to insert items into a full backpack. Fixes #75302 .
Describe the solution
If the examined pocket does not satisfy
pocket.can_contain()withignore_contents=true, then the pocket wouldn't be eligible anyway, and we had better use the failure reason from another pocket that presumably would be eligible.In effect, the failure reason when inserting "plastic painkiller bottle" into a full backpack will now instead be "not enough space".
Describe alternatives you've considered
Testing
Additional context