Appease clang #75271
Merged
Appease clang #75271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of these seem to be breaking the same clang-tidy rule, but they're only sporadically detected. Make them not break the rule by changing how they're used to add the two spaces on use.
github-actions
bot
added
Info / User Interface
Qrox
reviewed
Jul 28, 2024
ehughsbaird
force-pushed
the
appease-clang
branch
from
53e63e7 to
a1430ee
Compare
github-actions
bot
added
astyled
Co-authored-by: Jianxiang Wang (王健翔) <[email protected]>
ehughsbaird
force-pushed
the
appease-clang
branch
from
a1430ee to
4eef801
Compare
github-actions
bot
added
astyled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Fix clang-tidy issues reported on my PR that aren't generated by my PR: https://github.com/CleverRaven/Cataclysm-DDA/actions/runs/10120858531/job/27991135010?pr=75236
Describe the solution
Save/load a variable.
Move the two trailing spaces after a period in some strings to be added when the strings are used, so clang-tidy doesn't complain about them. Remove an unused variable.
Testing
Take a picture of someone being boomered.
Change withdrawal distractions in the distraction manager to false, see it is preserved after closing and restarting the game.