-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Withdrawals are distracting #75261
Withdrawals are distracting #75261
Conversation
added withdrawal distraction to manager
added distraction_withdrawal
depluralize withdrawal
add withdrawal interrupt to suffer.cpp
added withdrawal as a distraction type
addd withdrawal to activity type
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Just noticed there appears to be a clang tidy warning that was missed before I merged this. If you look at other PRs clang tests after this merged I’m seeing a couple mentions of withdrawal distractions. |
Oh shit, really? I'll take a look and upload a fix if i can figure it out on my own. |
So if i'm understanding this right, clang's saying that there's no test set up for it, but it should have one? So I should add this uistate option to one of the clang tests so it knows how to toggle it for automated testing? So it's not so much that there's a bug, it's that there's a feature missing for testing, and it's a problem that the feature isn't there? |
Afaik all the other PRs are running versions from before this PR. I think what's going on is the UI is trying to load in distraction_withdrawla from jsons that dont have it because they were made earlier. I will check later to see if this is still happening. If anyone knows let me know if i'm wrong. I'm happy to try and fix this if it isn't just a quirk of the game updating. |
Summary
Interface "Addiction withdrawals are a toggleable distraction"
Purpose of change
Addictions have been annoying because withdrawals can reduce your stats while working on some long-term task, infinitely extending the task as you suffer more withdrawals while trying to complete it. The addiction system in game asks you to satsfy it but doesnt stop you from passing out trying to practice some activity. Despite causing distracting pain, there has been no distraction to interrupt or notify you. Unlike asthma etc.
Describe the solution
Now, you can enable/disable withdrawals as a distraction, meaning they will stop your activity before your character gets horrible withdrawal symptoms, giving you a means to address them. RPing a junkie has never been easier! If the distraction messages get annoying, you can ignore them or toggle them off in the distractions menu. Fixes Issue #75195
Describe alternatives you've considered
Auto-consuming drugs, which i'm still working on.
Testing
Tested in basic build, seems to work great.
Additional context