-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved] Add the To Bless the Sacred Weapon charm #75249
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mechanics: Enchantments / Spells
Enchantments and spells
EOC: Effects On Condition
Anything concerning Effects On Condition
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Jul 26, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
json-styled
JSON lint passed, label assigned by github actions
astyled
astyled PR, label is assigned by github actions
labels
Jul 26, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved] Add the To Bless the Sacred Weapon charm"
Purpose of change
Had this idea and wanted to see if I could get it to work, based on this passage from Robert E. Howard's The Black Stone
And I thought, what if you could use hedge magic to bless a weapon against the creatures of the Nether?
Describe the solution
Add the aforementioned charm. It takes salt, wild herbs, and a lit candle and only works on steel or iron weapons but when active, the weapon does an extra 5 to 25 damage when used against Nether creatures. Implement a
BLESSED_WEAPON
flag, which the EoC that does the damage checks for, and aHEDGE_ENCHANTED
flag, used so that EoCs can check for items that have hedge magic charms on them. This allows for (for example) items that just come with theBLESSED_WEAPON
flag and always work, some kind of inherently holy blade, whereas an item withBLESSED_WEAPON
andHEDGE_ENCHANTED
will lose the charm if it suffers enough damage.Describe alternatives you've considered
Testing
The charm works.
Weapon does extra damage against Nether creatures but not against non-Nether creatures.
Weapon does not do extra damage when missing.
When weapon is damaged, the charm fades.
Additional context
I wanted to add the Sefer Raziel Hamalakh and put this charm in there, but I'll wait until I have a couple more charms to go with it (probably protective amulets).