Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xedra Evolved] Add the To Bless the Sacred Weapon charm #75249

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 26, 2024

Summary

Mods "[Xedra Evolved] Add the To Bless the Sacred Weapon charm"

Purpose of change

Had this idea and wanted to see if I could get it to work, based on this passage from Robert E. Howard's The Black Stone

and I read, too, of the lost, grim black cavern high in the hills where the horrified Turks hemmed a monstrous, bloated, wallowing toad-like being and slew it with flame and ancient steel blessed in old times by Muhammad, and with incantations that were old when Arabia was young.

And I thought, what if you could use hedge magic to bless a weapon against the creatures of the Nether?

Describe the solution

Add the aforementioned charm. It takes salt, wild herbs, and a lit candle and only works on steel or iron weapons but when active, the weapon does an extra 5 to 25 damage when used against Nether creatures. Implement a BLESSED_WEAPON flag, which the EoC that does the damage checks for, and a HEDGE_ENCHANTED flag, used so that EoCs can check for items that have hedge magic charms on them. This allows for (for example) items that just come with the BLESSED_WEAPON flag and always work, some kind of inherently holy blade, whereas an item with BLESSED_WEAPON and HEDGE_ENCHANTED will lose the charm if it suffers enough damage.

Describe alternatives you've considered

Testing

image
image

The charm works.
Weapon does extra damage against Nether creatures but not against non-Nether creatures.
Weapon does not do extra damage when missing.
When weapon is damaged, the charm fades.

Additional context

I wanted to add the Sefer Raziel Hamalakh and put this charm in there, but I'll wait until I have a couple more charms to go with it (probably protective amulets).

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mechanics: Enchantments / Spells Enchantments and spells EOC: Effects On Condition Anything concerning Effects On Condition Mods: Xedra Evolved Anything to do with Xedra Evolved labels Jul 26, 2024
@github-actions github-actions bot requested a review from Maleclypse July 26, 2024 05:00
@Standing-Storm Standing-Storm marked this pull request as draft July 26, 2024 05:00
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Ensorcell an iron or steel weapon that you are holding so it does additional damage to unholy creatures when used in melee combat. If the weapon is too damaged, the charm will cease to function.
  • You pass the weapon through the candleflame after rubbing the mixture of salt and herbs on it while slowly reciting the words of the charm, and when you have finished you feel a sense of surety while holding it

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 26, 2024
@Standing-Storm Standing-Storm marked this pull request as ready for review July 26, 2024 05:16
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 26, 2024
@Maleclypse Maleclypse merged commit a1981d3 into CleverRaven:master Jul 26, 2024
27 checks passed
@Standing-Storm Standing-Storm deleted the blessed-weapon branch July 26, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions EOC: Effects On Condition Anything concerning Effects On Condition [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mechanics: Enchantments / Spells Enchantments and spells Mods: Xedra Evolved Anything to do with Xedra Evolved Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants