Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Make the Artificer and Storm Elemental attunements innately immune to EMPs #75239

Merged
merged 3 commits into from
Jul 26, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 25, 2024

Summary

Mods "[Magiclysm] Make the Artificer and Storm Elemental attunement innately immune to EMPs"

Purpose of change

If anyone should be immune to having their gear broken by EMP, it's the Stormshaper/Technomancer attunement. Their gear should last until it has a chance to go out in a glorious explosion.

The Storm Elemental attunement also says:

You can better withstand the power of electricity

And they're already immune to electricity.

Describe the solution

Add the EMP_IMMUNE flag to the trait flags.

Describe alternatives you've considered

Testing

Additional context

@Standing-Storm Standing-Storm changed the title [Magiclysm] Make the Artificer attunement innately immune to EMPs [Magiclysm] Make the Artificer and Storm Elemental attunements innately immune to EMPs Jul 25, 2024
@github-actions github-actions bot added Mods Issues related to mods or modding [JSON] Changes (can be) made in JSON Mods: Magiclysm Anything to do with the Magiclysm mod labels Jul 25, 2024
@github-actions github-actions bot requested a review from KorGgenT July 25, 2024 20:28
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 25, 2024
@Maleclypse Maleclypse merged commit c336181 into CleverRaven:master Jul 26, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the artificer-emp-immune branch July 26, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants