Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Russian "ё" to remove_accent function #75234

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Added Russian "ё" to remove_accent function #75234

merged 1 commit into from
Jul 28, 2024

Conversation

achpile
Copy link
Contributor

@achpile achpile commented Jul 25, 2024

Summary

I18N "Added Russian 'ё' to remove_accent function"

Purpose of change

In Russian language we often use "е" instead of "ё". (not interchangeable). So when an item name has 'ё' the search query should have it either.

And despite what said in lang/notes/ru.txt:

Также не стоит забывать про букву Ё.
(Do not forget about letter Ё)

Sometimes there is Е where Ё should be.

Describe the solution

I added Ё to remove_accent function to make it easier for russian players to search

Describe alternatives you've considered

None

Testing

None

Additional context

Probably needs discussion with russian devs.
I mean if there is a reason it haven't been done earlier.

@github-actions github-actions bot added [C++] Changes (can be) made in C++. Previously named `Code` Translation I18n astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 25, 2024
@Maleclypse Maleclypse requested a review from ZhilkinSerg July 25, 2024 18:18
@achpile
Copy link
Contributor Author

achpile commented Jul 26, 2024

Not sure how to properly ask for this, but could this also be cherry-picked to 0.H ? And if yes - what should I do to achieve that?

@GuardianDll
Copy link
Member

Make a branch out of 0.H branch, and commit it to 0.H
I agree with it

@achpile
Copy link
Contributor Author

achpile commented Jul 26, 2024

Make a branch out of 0.H branch, and commit it to 0.H I agree with it

Great! I'll do it as soon as this PR got merged.

@GuardianDll
Copy link
Member

Technically nothing stops you from doing it before the pr is merged :)

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 28, 2024
@Maleclypse Maleclypse merged commit 14844ab into CleverRaven:master Jul 28, 2024
22 of 28 checks passed
@achpile achpile deleted the remove_accent branch July 29, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` json-styled JSON lint passed, label assigned by github actions Translation I18n
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants