Added Russian "ё" to remove_accent function #75234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I18N "Added Russian 'ё' to remove_accent function"
Purpose of change
In Russian language we often use "е" instead of "ё". (not interchangeable). So when an item name has 'ё' the search query should have it either.
And despite what said in
lang/notes/ru.txt
:Sometimes there is Е where Ё should be.
Describe the solution
I added Ё to
remove_accent
function to make it easier for russian players to searchDescribe alternatives you've considered
None
Testing
None
Additional context
Probably needs discussion with russian devs.
I mean if there is a reason it haven't been done earlier.