Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue cleaning up dog JSON #75231

Merged
merged 2 commits into from
Jul 26, 2024
Merged

Conversation

Karol1223
Copy link
Contributor

Summary

None

Purpose of change

#74645 did a lot of great work, but there was still lots lacking in the mutant dog department, and some more room for cleanup in normal dog definitions

Describe the solution

  • Introduced a new small dog abstract for the dogs that are too small to zombify to copy from
  • Removed HARDTOSHOOT from all the pups and small dog breeds - they aren't something unnaturally hard to shoot, regular size calculations will suffice
  • Removed the manually added diff field to the boxer pup - not only there was ZERO reason for it to be there, as the pup had nothing that the autocalculation wouldn't catch, it propelled the pup's difficulty to higher than that of a default zombie????
  • Removed one unused field from the default pup definition
  • Removed one unused field from the triclopean dog
  • Unified the pup HP across the board, since they're all the same size anyway - also lowered it significantly for most - the only exception is the Chihuahua puppy as it does indeed have a unique size field
  • Changed mutant dog pups to actually copy from the puppy, not adult dog definition - by doing so cut out 90% of their lines
  • Chained adult mutant dogs to the labrador via copy-from
  • Removed Mongrel reproduction - for some reason those horribly mutated dogs of unknown breed gave birth to Labrador puppies ????
  • Lowered the grab strength for the mutant dog that happens to have claws to not be higher than a dead human corpse with actual hands
  • Made mutant dogs zombify into zombie dogs, not the flesh cocoons

Describe alternatives you've considered

  • taking a deeper look into factions - I honestly so don't want to it's unreal
  • introducing a new tiny puppy abstract - not worth it for so few lines saved, maybe if we ever get more small dog breeds
  • handling the Mauler and Thrasher special attacks via extend, but since they don't bark it's too much hassle

Testing

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Monsters Monsters both friendly and unfriendly. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 25, 2024
@Maleclypse
Copy link
Member

Isn't dog grab strength actually a bite grab? Or have I just been imagining that?

@Karol1223
Copy link
Contributor Author

Karol1223 commented Jul 26, 2024

Isn't dog grab strength actually a bite grab? Or have I just been imagining that?

In zombie dogs it is (and it's even weaker, at 10). In living dogs, we don't have grabs normally, so I assume the one with claws gets it due to claws.

@Maleclypse Maleclypse merged commit 42258b3 into CleverRaven:master Jul 26, 2024
26 checks passed
@Karol1223 Karol1223 deleted the chain-the-doggy branch July 26, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Monsters Monsters both friendly and unfriendly.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants