-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xedra Evolved] Add Fulgurating Strikes Sylph trait #75198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standing-Storm
changed the title
[Xedra Evolved] Add Fulgurating Strikes Slyph trait
[Xedra Evolved] Add Fulgurating Strikes Sylph trait
Jul 23, 2024
github-actions
bot
added
[JSON]
Changes (can be) made in JSON
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Mods: Xedra Evolved
Anything to do with Xedra Evolved
labels
Jul 23, 2024
github-actions
bot
added
astyled
astyled PR, label is assigned by github actions
json-styled
JSON lint passed, label assigned by github actions
labels
Jul 23, 2024
github-actions
bot
added
EOC: Effects On Condition
Anything concerning Effects On Condition
and removed
json-styled
JSON lint passed, label assigned by github actions
labels
Jul 23, 2024
github-actions
bot
added
the
Mechanics: Enchantments / Spells
Enchantments and spells
label
Jul 23, 2024
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
github-actions
bot
added
the
json-styled
JSON lint passed, label assigned by github actions
label
Jul 24, 2024
github-actions
bot
added
the
BasicBuildPassed
This PR builds correctly, label assigned by github actions
label
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
astyled
astyled PR, label is assigned by github actions
BasicBuildPassed
This PR builds correctly, label assigned by github actions
EOC: Effects On Condition
Anything concerning Effects On Condition
[JSON]
Changes (can be) made in JSON
json-styled
JSON lint passed, label assigned by github actions
Mechanics: Enchantments / Spells
Enchantments and spells
Mods: Xedra Evolved
Anything to do with Xedra Evolved
Mods
Issues related to mods or modding
Mutations / Traits / Professions/ Hobbies
Mutations / Traits / Professions/ Hobbies
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mods "[Xedra Evolved] Add Fulgurating Strikes Sylph trait"
Purpose of change
Sylphs don't have a trait that makes lightning explode everywhere while they fight. I feel like that needs to change
Describe the solution
Add Fulgurating Strikes, a trait that adds an electrical charge to the Sylph's attacks. Each attack costs mana while the trait is active.
If the Sylph knows the more powerful lightning spells, then the attack also blasts electric fields around them when they attack.
Describe alternatives you've considered
Testing
Trait exists, lightning damage applies on melee attacks, with enough magical knowledge, there are bursts of lightning fields too. Each attack costs mana. If you run out of mana, the trait turns off.
Additional context