Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Reduce effect of Gaia's Chosen thorns #75174

Merged
merged 5 commits into from
Jul 24, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 22, 2024

Summary

Mods "[Magiclysm] Reduce effect of Gaia's Chosen thorns"

Purpose of change

Gaia's Chosen has a thorns effect that does a flat 22 damage (more than a KA-BAR knife), passively, to anyone who hits you. Normal zombies will die in four hits, and even stronger zombies will crumble pretty quickly. Couple that with their protective spell and you don't even need to hit tab, you can just pass turns with . and hordes will kill themselves as they attack you, completely eliminating the limitation of mana as a resource.

It's too much, even for an attunement.

Also, the design docs say

but give increased pain when hit

And that part was not implemented.

Describe the solution

Reduce and randomize the damage from thorns--now it does 3-12 damage and only triggers 50% of the time. In addition, add an enchant that Gaia's Chosen suffers 15% increased pain. Add a line to the trait warning about increased pain.

Describe alternatives you've considered

Testing

Additional context

@github-actions github-actions bot requested a review from KorGgenT July 22, 2024 21:36
@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels Jul 22, 2024
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions labels Jul 22, 2024
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 23, 2024
@Maleclypse
Copy link
Member

Hmm something was merged adding different numbers for these effects

@Standing-Storm
Copy link
Contributor Author

It looks like a non-final version somehow got included into #75177. I have no idea how that happened.

@Maleclypse Maleclypse merged commit 83684b5 into CleverRaven:master Jul 24, 2024
20 of 24 checks passed
@Standing-Storm Standing-Storm deleted the gaias-thorns-nerf branch July 24, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants