Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Magiclysm] Artificer attunement passively recharges batteries in inventory #75161

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Standing-Storm
Copy link
Contributor

@Standing-Storm Standing-Storm commented Jul 22, 2024

Summary

Mods "[Magiclysm] Artificer attunement passively recharges batteries in inventory"

Purpose of change

This was on the Magiclysm design docs but hadn't been implemented yet.

Describe the solution

Implement an EoC that runs when you have the Artificer attunement. Every minute, it adds power to all batteries in inventory equal to the total levels in your Artificer attunement spells.

It only works on loose batteries because the docs said "batteries," so I went with the simpler implementation.

Describe alternatives you've considered

Testing

It works.

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Mods: Magiclysm Anything to do with the Magiclysm mod labels Jul 22, 2024
@github-actions github-actions bot requested a review from KorGgenT July 22, 2024 16:18
@github-actions github-actions bot added astyled astyled PR, label is assigned by github actions json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Jul 22, 2024
@Maleclypse Maleclypse merged commit 13a1a5f into CleverRaven:master Jul 22, 2024
23 of 27 checks passed
@Standing-Storm Standing-Storm deleted the artificer-batteries branch July 23, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Magiclysm Anything to do with the Magiclysm mod Mods Issues related to mods or modding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants