Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Civilianize G36 #75154

Merged
merged 12 commits into from
Jul 22, 2024
Merged

Civilianize G36 #75154

merged 12 commits into from
Jul 22, 2024

Conversation

Holli-Git
Copy link
Contributor

Summary

Balance "Replace G36 with SL8"

Purpose of change

The G36 doesn't really exist in the USA due to import restrictions. There are some that are converted SL8s, but not really a G36, and the SL8 are more common anyways.

Describe the solution

Removes the G36, replaces it with the SL8

Describe alternatives you've considered

Just removing the G36, or having it be the tommy built ones, also still removing them from police stuff.

Testing

Before migration:
image
After:
image
I migrated it to the SIG SG 556 as I felt "weird import gun with polymer magazine"

The gun:
image

It spawning:
image

Additional context

I was going to add 5 rounders, but it seems those only exist in Canada

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Magazines Ammo holding items and objects. Spawn Creatures, items, vehicles, locations appearing on map Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Mods: Generic Guns Anything to do with Generic Guns Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Items: Armor / Clothing Armor and clothing labels Jul 22, 2024
@github-actions github-actions bot requested a review from I-am-Erk July 22, 2024 02:12
@github-actions github-actions bot added Game: Balance Balancing of (existing) in-game features. json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Jul 22, 2024
@Holli-Git Holli-Git requested a review from tenmillimaster July 22, 2024 02:13
Copy link
Member

@tenmillimaster tenmillimaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I double checked GunBroker historical, we're in the 300's, which was shocking.

data/json/items/gun/223.json Outdated Show resolved Hide resolved
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • The SL8 is an importation-legal gun similar to the German G36, made to be semi-auto only, and to only feed from 10 round single stack magazines. It also features a distinctive thumbhole stock, a polymer handguard, and a top rail for mounting optics.

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Jul 22, 2024
@Maleclypse Maleclypse merged commit 28fe361 into CleverRaven:master Jul 22, 2024
18 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Code: Tests Measurement, self-control, statistics, balancing. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Game: Balance Balancing of (existing) in-game features. Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items: Armor / Clothing Armor and clothing Items: Magazines Ammo holding items and objects. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Mods: Dark Days of the Dead Anything related to the DDotD mod (classic style zombies) Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants